-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/windows build #2
base: master
Are you sure you want to change the base?
Conversation
Chars "<" and ">" not support rc.exe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
Sandro Santilli <strk@kbt.io> - GEOS | ||
J Smith <dark.panda@gmail.com> <jay@php.net> - PHP packaging | ||
Sandro Santilli strk@kbt.io - GEOS | ||
J Smith dark.panda@gmail.com jay@php.net - PHP packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this format change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of < > The RC resource compiler crashes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like an upstream bug. The current one does not crash, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the current version compiles without errors
Sandro Santilli <strk@kbt.io> - GEOS | ||
J Smith <dark.panda@gmail.com> <jay@php.net> - PHP packaging | ||
Sandro Santilli strk@kbt.io - GEOS | ||
J Smith dark.panda@gmail.com jay@php.net - PHP packaging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds like an upstream bug. The current one does not crash, right ?
Many thanks @eisberg! |
Hi, |
Can we decouple the PHP8 functionality from this PR and introduce it as its own? |
Hi, |
Added Window Build
See new release in fork: https://github.com/ModelTech/php-geos/releases/tag/1.0.1